Comment by Aeolun
7 years ago
I think the point is, whenever I fork a piece of code, fix something, and push the fix back upstream, there’s a whole set of things I apparently didn’t do to the maintainers liking.
I don’t want to deal with that...
7 years ago
I think the point is, whenever I fork a piece of code, fix something, and push the fix back upstream, there’s a whole set of things I apparently didn’t do to the maintainers liking.
I don’t want to deal with that...
My favorite is when they demand you write tests for a three-line change to code that has no tests.
In their defence, deciding you're going to require new tests for all new additions in a pretty effective way to get out of the 'there are no tests' situation. I recently heard something along the lines of "don't bother adding new tests, this project barely has any tests anyway" about a project where I have been trying to increase test coverage whenever I have to make a change in recent months. With that attitude it's no surprise the project barely had any tests...
Naturally it is not a reasonable request when there is no existing testing infrastructure yet.