← Back to context

Comment by jeltz

5 years ago

People did investigate for him and write a patch for him and he dismissed the patch with it being "boring".

4 comments

jeltz

Reply
zzzcpan  5 years ago

Well, maybe people didn't provide detailed enough explanation for the author to understand and merge the patch, so he didn't bother.

  • jeltz  5 years ago

    Judge for yourself: https://web.archive.org/web/20200116203731/https://github.co...

    • ryandrake  5 years ago

      It seems like the better solution here would have been for the folks who wanted a fixed version of the software to create and maintain a "actix-done-right" fork themselves. This is what we all do in the professional world when a maintainer doesn't want to upstream critical patches for whatever reason.

      They're under no obligation to upstream your patch, but it's open source so you're not powerless either! Why so much drama over a rejected PR?

      1 reply →