Comment by AzzieElbab
5 years ago
would you have declined a patch that fixes a real problem because it is boring? i do not really get that kind of thinking either. personally i would have accepted it and replaced with something clever latter on
5 years ago
would you have declined a patch that fixes a real problem because it is boring? i do not really get that kind of thinking either. personally i would have accepted it and replaced with something clever latter on
Yes, I would. Because that patch is a "style" patch. It's not important in the author's roadmap for the project.
People ask for different things and think their things are the most important, and when they don't get their way, screaming and kicking to force them in. They can always fork it or create a separate project if it's so important.
I wrote "fixes a problem" explicitly. How is that a "style" patch?
Some people treat style as a problem. In the context of “boring” conversation the problem was the unsafe usage. How’s that not style?