Comment by detaro
5 years ago
They claim they don't want to exclude projects that don't merge through the PR feature: https://twitter.com/MattIPv4/status/1311388583136301059
They probably should validate a somewhat matching commit with the same e-mail address ending up in a branch or something. Few if any projects modify those.
Not a good reason. What about people who don't use GitHub at all? Why are they excluding them then?
All projects _not_ using GitHub are already excluded.
That's my point :) Arguing that because this would exclude some small number of projects does not make sense if from the get go you exclude a large number of open source projects.
Is there a logical fallacy where you appeal to only the rarest of circumstances? You want your t-shirt? Find some repo that uses PRs normally.
I'd love to know the name of it if there is! It seems to happen quite a bit.
Just a piece of anecdata in regards to this, last year in my first Hacktoberfest I made a PR for an open issue on a project that got no response from the maintainer until a week later, where he said something along the lines of "Oh sorry, I missed this one, I'll get to it soon", and then he just never reviewed it or anything else on the project ever again.
That's a perfectly normal Github experience, so it wouldn't invalidate the metric.
Do more than the bare minimum for your tee then. Hedge your bets.