Comment by tmp538394722
5 years ago
Merging a PR requires effort from the maintainer.
I frequently perceive a sense of entitlement from drive by PR contributors, as if they are giving a gift to the maintainer, when in reality, it often takes more time for the maintainer to test, review, and give feedback on contributions than if they’d done it themselves.
I imagine the people spamming repositories for a T-shirt are the same people who will harass maintainers to “just merge it already.”
I don’t see conflict with this requirement. Maintainers should not feel pressure to speed through or acceptance.
This means not all os projects are likely to yield you a t-shirt, but it does mean your contributions must be good and relevant to have a chance.
There is some technique to reviewing a project and knowing what is likely to be pulled based on its context.
That aught to cut down on it.
Fwiw, DO should be doing something for the projects that accept a PR from this “fest” either t-shirts or a donation to a foss advocacy org or similar.
This is one reason why I generally open an issue first. Lets talk about my problem first. Maybe I add a PR / branch / patch as a PoC. Maybe it gets closed with "No" a few month later.
However, I don't see how that works with a hackaton mindset.
>I frequently perceive a sense of entitlement from drive by PR contributors, as if they are giving a gift to the maintainer, when in reality, it often takes more time for the maintainer to test, review, and give feedback on contributions than if they’d done it themselves.
If that's what you think then why accept pull requests at all on your project?
Well for one, last time I checked GH doesn’t allow this in their UI.
And on balance, I love open source!
It’s just one of those unfortunate things where it’s hard and slow to be considerate while being easy and cheap to be inconsiderate.