← Back to context

Comment by mtlynch

5 years ago

This is unfortunate, and I agree with other commenters that Hacktoberfest should be opt-in.

I had a great experience with Hacktoberfest last year. I tagged a few issues with Hacktoberfest and got a nice PR from someone showing me how to configure my Vue project for unit testing.[0] It was a non-trivial PR and a useful contribution.

https://github.com/mtlynch/whatgotdone/issues/279

7 comments

mtlynch

Reply
adamsvystun  5 years ago

It seems that the person responsible for the project proposed this to be opt-in [1], but it never got anywhere internally.

[1] https://twitter.com/MattIPv4/status/1311391325443555328

  • tom_mellior  5 years ago

    If they can't make it opt-in, at the very least they should:

    1. Only count PRs that contain something like "#Hacktoberfest" in the GitHub comment accompanying the PR. This would make it easier for maintainers to weed out the spam or at least understand where it's coming from and what term to search for when they encounter this unprepared. Also, it would give "visibility" to the event, so it should even fly with management!

    2. Only count merged PRs. Apparently DigitalOcean have a "reason" for not doing this, because some projects don't use the PR merging feature directly. I think they should reward users who educated themselves on this point and only opened PRs on projects that do merge them.

    • MivLives  5 years ago

      1. Should be the case for sure.

      2. I think the other argument you could make against that is not everyone has the same time to merge. If it takes two weeks to get merged, I basically have to have the PR in by the second week of October.

      2 replies →

josteink  5 years ago

> I had a great experience with Hacktoberfest last year.

Yeah same here, but as a contributor. I decided I wanted to make my PRs count and decided on a targeted effort of taking one mans tiling WM for Windows[1] and fixing enough of the stability issues and race-conditions I found to the point where I should be able to use it myself.

Not a single one of those PRs was “cheap”, and the resulting improvements in quality and stability has lead that WM now to seemingly have more users and doing better than it used to.

And now I have a tiling WM whick is actually usable the times I have to use Windows. Win win, as far as both I and that project-owner is concerned.

[1] https://github.com/rickbutton/workspacer