← Back to context

Comment by int_19h

5 years ago

On pretty much any other web page, Ctrl+F will search whatever is on the page; why should Discourse be any different?

I don't mind them having a server-side search function that actually searches the entire thread. I do mind having a heavily-used shortcut hijacked to behave in a non-standard way.

Try pressing CTRL+F twice and see what happens

  • Oh, I'm well aware of this workaround. The problem is that Ctrl+F is muscle memory by now, so I usually hit it and immediately start typing... then notice that it's the wrong search, swear, hit it again, and type again.

Because to remain performant, modem sites remove elements that have been scrolled too far off the page. So native ctrl + f would not be searching very much at all.

I don't see the problem with this tbh. When you create a JS app, you lose a lot of the native features of the browser and it becomes your own responsibility to reimplement them in a correct way. As long as the site pulls it off flawlessly, this is ok to me.

And from what I have seen, discourse does do this well.

  • > to remain performant, modem sites remove elements that have been scrolled too far off the page

    This is done to remain performant specifically when the website thinks infinite scrolling is a good idea. In my experience it very rarely is, with the Ctrl+F thing being just one of the reasons why.