← Back to context

Comment by tomtheelder

4 years ago

Not the original commenter, but just using `by` makes total sense to me.

I've made this change [1]. Thank you!

[1] https://github.com/max-sixty/prql/commit/dde7fcfc13daaadbdce...

  • FWIW the separate `group_by()` is one of my greatest design regrets with dplyr — I wish I had made `by` a parameter of `summarise()`, `mutate()`, `filter()` etc.

    • Thanks for commenting! I hope you can see the influence of dplyr & tidyverse here. Please let me know if you have any other feedback!

    • Is it too deeply entrenched to change? The number of times I have had a data.frame grouped when it wasn't supposed to be, I can count on my fingers. But the hours that I spent trying to figure it out must amount to a paycheck or two.

      2 replies →