← Back to context

Comment by zzzeek

3 years ago

the period right there on the left edge? if I saw that in a patch I'd be through the roof, that looks completely intentional

6 comments

zzzeek

Reply
aeyes  3 years ago

I'd never suspect this to be intentional if I'd spot it in a patch, even given the consequences in this particular case. I have written and committed things into code instead of writing it into some other window several times. Without a linter I probably wouldn't spot an extra dot when reviewing my own change before sending it out.

throwaway2037  3 years ago

I love this type of hindsight to 20-10 comment. "If I saw...". That is a BIG if. Plenty of smart people on that mailing also missed it. I missed it myself when I opened the HN lead link. Very subtle.

  • zzzeek  3 years ago

    I dont use mailing lists for patches, I use gerrit that would put a great big highlight over that character

Tuna-Fish  3 years ago

I distinctly remember having to remove such a superfluous . that I accidentally added into a file on multiple occasions.

If you are using vi and your left shift key is dodgy, that can easily happen by accident.

kristopolous  3 years ago

Not me. Maybe someone is using an editor with a . key mapped to something. It's in a pretty convenient place.

:wq!