← Back to context

Comment by whoitwas

2 years ago

Agreed. A good policy is to include ticket number and a short description.

I save that and one or more “Reviewed-by” trailers for the merge commit message (Yes! You can write commit messages there too!)

Meh, you can easily twist that into a bad policy, too (and yes, people do that). At work, some of my colleagues litter many repos (I don't usually have to work with, thankfully) with dozens of commits having the same ticket ID and the title of the ticket as their subject. Usually pushed straight to trunk (full of foxtrot merges if two people work at the same time). And in the message body, then, there's usually the unhelpful "fix typo".

My opinion: Write readable messages, scope your commits to simple changes, put them on a branch, use `--autosquash`, put the ticket ID in the merge commit's message. It really isn't hard.