Comment by themanmaran
3 days ago
Hey Tammilore. I see your updates to the README and it's appreciated.
And I don't mind people building on top of zerox of course, that's why it's open source. I flagged this because it was originally passed off as your own work.
Although general best practice here would be to fork the repo, that way you could make updates, and always pull in upstream changes as we roll them out. It seems like your implementation [1] could have very easily just pulled in the npm package.
[1] https://github.com/DocumindHQ/documind/blob/main/extractor/s...
(Also very minor nit, you don't need an await on the `generateMarkdownDocument` function)
Thanks for pointing this out, and I get where you're coming from. I didn’t mean to make it seem like Zerox wasn’t part of the project— which was why I included the MIT license both in the relevant code and the root file to make sure it was properly acknowledged.
On the forking thing, I honestly didn’t think it was necessary since cloning and modifying seemed fine for the use case, but I see how forking might’ve made things clearer. I’ll keep that in mind going forward.
Appreciate the heads-up about generateMarkdownDocument, too—I’ll fix that!