Comment by mustache_kimono

10 months ago

> The thread was not about Rust drivers, it was about adding Rust code to the DMA module. I.e. about mixing two different languages in a single module

AFAIK this is false. The patch was CCed to the maintainer as FYI, but all the code was in a Rust a module binding to the C DMA interface. If I'm wrong, show me the code.

See the discussion here: https://lkml.org/lkml/2025/1/9/398

3 comments

mustache_kimono

fluoridation 10 months ago

I'm just going by what was mentioned in the thread. If that interpretation is wrong, the thread makes no sense.

mustache_kimono 10 months ago
Fine. But, when I say something is out in out false, it might be worth checking your facts.
I'm willing to grant that it is possible Christoph Hellwig simply misunderstood the patch and overreacted.
rust/bindings/bindings_helper.h | 1 + rust/kernel/dma.rs | 271 ++++++++++++++++++++++++++++++++ rust/kernel/error.rs | 1 + rust/kernel/lib.rs | 1 + 4 files changed, 274 insertions(+) create mode 100644 rust/kernel/dma.rs
See: https://lkml.org/lkml/2025/1/8/801
See: https://lkml.org/lkml/2025/1/9/398
See: https://lkml.org/lkml/2025/1/10/619
See: https://lkml.org/lkml/2025/1/29/999
dralley 10 months ago

>I'm just going by what was mentioned in the thread. If that interpretation is wrong, the thread makes no sense.
You've now discovered why this blew up in the first place. All of the excuses used to reject the code were not just petty but also outright false, and trivially so.