← Back to context

Comment by hydroxideOH-

3 days ago

I use the GitHub Pull Request extension in VSCode to do the same thing (reviewing code locally in my editor). It works pretty well, and you can add/review comments directly in the editor.

9 comments

hydroxideOH-

Reply
ivanjermakov  3 days ago

It's better, but still quite deep vendor lock-in (in both GitHub and VSCode).

  • hydroxideOH-  3 days ago

    Well my employer chooses to use GitHub so I don’t have a choice there. And it’s vendor lock-in VSCode but that’s already my primary editor so it means there’s no need to learn another tool just for code review.

  • cyberax  3 days ago

    JetBrains IDEs can do the same.

    • plonq  3 days ago

      Unfortunately it’s not feature complete - you can’t paste images in review comments, for example. Still very useful for large PRs though.

  • NortySpock  3 days ago

    GitHub may be dominant, but it's not like it doesn't have competitors nipping at its heels (GitLab, BitBucket come to mind).

    VSCode is open source, and there are plenty of IDEs...

    I guess I'm just focused on different lock-in concerns than you are.

pm90  3 days ago

Same! Its much nicer now especially since Github seems to be pretty arbitrary/rigid about when it hides files that have "too many changes". Its so much nicer to see/navigate around such changes quickly in VSCode vs trying to do the same in the web interface.

I suspect that since this is possible with VSCode/Github, its probably extensible to other providers editors.

cebert  3 days ago

I use this a lot too. Also, if you open a PR on the GitHub website and press the “.” key, it opens the review in VSCode, which I consider a much better web experience.