← Back to context

Comment by tomalbrc

6 months ago

This has to be a joke, right? Months of effort for a makefile? In which world do people live these days

You seriously underestimate this in general case. Build system may be made in weeks, but is polished in months or even years, to account for all the different usage and environment scenarios. Otherwise, it's typically very fragile.

  • Which is why I think you should not try to build generic images like this. I looked at the source and it seems like s lot of work had been put into creating a fragile mess.

    After having been burned several times by images I prefer writing my docker images from scratch (based on the Debian or Alpine images) for production systems. I only use ready-made images for quickly getting something running locally to evaluate it.

The effort you put into a work doesn't determine copyright. You can own the copyright to a photograph that took seconds to take. And you can spend every hour of the day keeping a meticulous log of room temperature, and not have a copyright, because a table of facts isn't copyrightable.

Wasn't the point of the post you replied to that it isn't just a simple makefile ? That repo contains quite a lot carefully assembled scripts for each image that handles a lot of corner cases.

Tell me you haven't ever written even a moderately complex Makefile without telling me you haven't ever written even a moderately complex Makefile.

It would only take you a weekend!

  • It is a lot of work but it is work that for the most part should not have been done. I took a quick look at the code (since I know PG very well) and I would not recommend anyone to use that mess off Bash code which configures PostgreSQL in an annoying and incorrect way and exposed some arbitrarily select settings in the environment (some very rarely used) while you have to do most in the config file. Better to just write your own Docker image for scratch, or use the official PG image of your needs are simple.

    This is what happens if you merge every feature request you get and do not have a clear plan or architecture. After reading the code I am happy they are deleting the images, at least if this one is typical.

    As a PostgreSQL expert I can write a much better image which suits my needs in one day, which I have also done several times. It would be harder for a non-expery but I do not think a non-expert should use this image due to some footguns I spotted. This kind of generic image is a bad idea and very hard to build.

    • > but I do not think a non-expert should use this image due to some footguns I spotted

      Could you elaborate on your findings?

    • Hindsight is 2020, there’s now helm/kubernetes operator under the cloud native umbrella. I’m sure they took in all the mistakes from here. This helm chart is getting long in the tooth, but is still monumental. Imo running psql on kube is a mistake to begin with but here we are.