Comment by machinate
11 hours ago
What issue are you taking with the code? Line breaks in the condition?
Presumably the last if statement in the diff.
11 hours ago
What issue are you taking with the code? Line breaks in the condition?
Presumably the last if statement in the diff.
There aren’t {} brackets after the if
Are you saying they should always be present? Or only when the condition takes multiple lines; i.e. do you take issue with the ifs in zone_name_pref too?
Personally I think the indentation does a good enough job here.