Comment by jacquesm
4 days ago
If you're going to use local allocation of short lived buffers then don't use malloc but use alloca. That's much cleaner.
http.c around line 398, that looks wrong.
4 days ago
If you're going to use local allocation of short lived buffers then don't use malloc but use alloca. That's much cleaner.
http.c around line 398, that looks wrong.
Arenas would be a better fit for a webserver. Allocations are basically free and everything gets deallocated all at once, so having one arena per active request and resetting it between requests can give very high performance.
Using alloca will result in stack overflows if you use more than a couple megabytes, so it isn't a very good idea.
Those buffers are tiny and they won't result in stack overflows because the whole thing is single threaded, it is beginner level code.
I've been told that modern compilers really don't like alloca, is that wrong?
I don't know who told you. But it's a lot slower than malloc, and requires you to do a bunch of bookkeeping, which is easy to mess up if you have multiple exits from your function.
> But it's a lot slower than malloc
How would it be slower? Isn't it simply bumping the stack pointer?
1 reply →
alloca is just a couple of instructions to allocate more memory on the stack, it is much faster than malloc for pretty much every reason including locality and the fact that it doesn't have to be freed because it goes away after the current scope.
2 replies →