← Back to context

Comment by jcalvinowens

7 days ago

I hate this. Delaying real bugfixes to achieve some nebulous poorly defined security benefit is just bad engineering.

The point is to apply a cooldown to your "dumb" and unaccountable automation, not to your own professional judgment as an engineer.

If there's a bugfix or security patch that applies to how your application uses the dependency, then you review the changes, manually update your version if you feel comfortable with those changes, and accept responsibility for the intervention if it turns out you made a mistake and rushed in some malicious code.

Meanwhile, most of the time, most changes pushed to dependencies are not even in the execution path of any given application that integration with them, and so don't need to be rushed in. And most others are "fixes" for issues that were apparently not presenting an eminent test failure or support crisis for your users and don't warrant being rushed in.

There's not really a downside here, for any software that's actually being actively maintained by a responsible engineer.

  • You're not thinking about the system dependencies.

    > Meanwhile, most of the time, most changes pushed to dependencies are not even in the execution path of any given application that integration with them

    Sorry, this is really ignorant. You don't appreciate how much churn their is in things like the kernel and glibc, even in stable branches.

    • > You're not thinking about the system dependencies.

      You're correct, because it's completely neurotic to worry about phantom bugs that have no actual presence of mind but must absolutely positively be resolved as soon as a candidate fix has been pushed.

      If there's a zero day vulnerability that affects your system, which is a rare but real thing, you can be notified and bypass a cooldown system.

      Otherwise, you've presumably either adapted your workflow to work around a bug or you never even recognized one was there. Either way, waiting an extra <cooldown> before applying a fix isn't going to harm you, but it will dampen the much more dramatic risk of instability and supply chain vulnerabilities associated with being on the bleeding edge.

      3 replies →

Do you upgrade all your dependencies every day? If not, then there’s no real difference in upgrading as if it were 7 days ago.

  • I upgrade all dependencies every time I deploy anything. If you don't, a zero day is going to bite you in the ass: that's the world we now live in.

    If upgrading like that scares you, your automated testing isn't good enough.

    On average, the most bug free Linux experience is to run the latest version of everything. I wasted much more time backporting bugfixes before I started doing that, than I have spent on new bugs since.

    • > zero day is going to bite you in the ass

      Maybe your codebase is truly filled with code that is that riddled with flaws, but:

      1) If so, updating will not save you from zero days, only from whatever bugs the developers have found.

      2) Most updates are not zero day patches. They are as likely to (unintentionally) introduce zero days as they are to patch them.

      3) In the case where a real issue is found, I can't imagine it isn't hard to use the aforementioned security vendors, and use their recommendations to force updates outside of a cooldown period.

      3 replies →

    • Upgrading to new version can also introduce new exploits, no amount of tests can find those.

      Some of these can be short-lived, existing only on a minor patch and fixed on the next one promptly but you’ll get it if you upgrade constantly on the latest blindly.

      There is always risks either way but latest version doesn’t mean the “best” version, mistakes, errors happens, performance degradation, etc.

      2 replies →

    • > I upgrade all dependencies every time I deploy anything. If you don't, a zero day is going to bite you in the ass: that's the world we now live in.

      I think you're using a different definition of zero day than what is standard. Any zero day vulnerability is not going to have a patch you can get with an update.

      8 replies →

  • Renovate (dependabot equiv I think) creates PRs, I usually walk through them every morning or when there's a bit of downtime. Playing with the idea to automerge patches and maybe even minor updates but up until now it's not that hard to keep up.

  • Your CI/CD might be setup to upgrade all your dependencies on every build.

    • I’ve seen a lot of CI/CD setups and I’ve never seen that. If that were common practice, it would certainly simplify the package manager, since there would be no need for lockfiles!

      2 replies →