← Back to context

Comment by WalterBright

3 days ago

Rewrite as:

    for (ptr = start; random_condition (*ptr); ptr = ptr->next) { }

Then anyone reading your code will know the empty loop was intentional. BTW, many C compilers warn about the ; on a for loop.

Have you ever discovered this bug:

    if (condition);
        doThis();

It's a hard one to see in a code review. Yes, that's also disallowed in D.

> I should use %lld for long long, but the printf implementation shipped with the compiler doesn't support that.

Weird that your compiler would support long long, but with a broken Standard library. I don't see that as a feature. You can always cast the argument to long, and at least you won't get undefined behavior.

3 comments

WalterBright

Reply
1718627440  3 days ago

> Rewrite as:

Could do that I just don't like the look. :-)

> Have you ever discovered this bug:

Actually no, because the coding style I use either puts it on a single line or with braces. I never indent just a single line.

So:

    if (condition) doThis ();

or:

    if (condition)
    {
        doThis ();
    }

> Weird that your compiler would support long long, but with a broken Standard library.

Yeah, for your information it was GCC combined with newlib for arm-none-eabi shipped with Debian/MS Windows.