Comment by Tepix

3 months ago

This sounds pretty cool, can I do pull requests across radicle instances?

gitlab recently closed a 2015 feature request https://gitlab.com/gitlab-org/gitlab/-/issues/14116

PS: What's this "AD" prefix you're using?

9 comments

Tepix

AD: Pull requests are `patches` in radicle, when you clone a repository you create a git namespace for yourself from which you can edit to your hearts desire, you can then open patches to other repos via this mechanism.

nh2 3 months ago
Are you open to rename the "patches" terminology?
Apparently currently "1 patch = 1 pull request of e.g. multiple commits" in Radicle.
That confusing, since in Git a patch usually refers to a single commit:
* git format-patch outputs 1 ".patch" file per commit. * Its output also enshrines that, in the subject lines that appear e.g. on Linux mailing lists: "[PATCH 1/2]", meaning "one of two patches in a patch series".
(That said, `git format-patch --stdout` can concatenate multiple commits into a single output, but it does not offer to write those into a single .patch file by itself.)
So when reading "Patches", I was intuitively unnecessarily scared that the tool cannot handle whole branches, and flattens out all commits.
Maybe "Patchsets"?
That's what kernel people apparently call them:
https://kernelnewbies.org/PatchPhilosophy#What_is_a_patchset...
https://kernelnewbies.org/PatchPhilosophy#Patches_are_git_co...
- endiangroup 3 months ago
  
  AD: Those are fair points, feel free to jump on our [zulip](https://radicle.zulipchat.com/#recent) and start a discussion there!
  
  1 reply →
happosai 3 months ago

This sounds really, really cool. How does reviewing such patch-PR's work?

endiangroup 3 months ago

AD: The prefix is my initials :) - my only HN account is a shared one with a co-op organisation I work through. I use AD to distinguish who's commenting... however my co-workers have yet to use this account ha!

nh2 3 months ago

If you replace "AD:" by "Adrian from Endian writing:", people won't have to wonder what "AD" means, and waste their and your time on asking (you will probably get this question a lot otherwise).
pseudalopex 3 months ago

Your initials form a word used as a disclaimer often. And shared HN accounts are not common.
aldonius 3 months ago

Thanks for clarifying.
Just for reference, usually folks in this situation use postfix initials rather than prefix (like how blockquotes are cited).
- J.S.