← Back to context

Comment by freedomben

13 hours ago

All of the https://github.com/AOSC-Tracking/jdk/ links 404 for me, so it's difficult to get a sense of what was being done. Going off of the "loongson fork" links though they look rather trivial. Not saying they should be ignored, but I do think trivial PRs to large critical open source projects like JDK can often end up taking more time away from contributing engineers doing reviews and testing than they are worth.

I know first-hand the frustration of having PRs ignored and it can be quite demoralizing, so I do feel for the author. It sounds like the author is getting to a place of peace with it, and my advice from having been down that path before is to do exactly that, and find something else interesting to hack on.

6 comments

freedomben

Reply
aeurielesn  12 hours ago

I disagree. Trivial PRs are perfect for first contributions, especially to get through the myriad of bots requesting you to sign/review stuff.

Having said that, I would never contribute to a project with a first contributor experience like this one.

  • zbentley  12 hours ago

    I don’t think you and GP disagree. Trivial PRs can be

    > perfect for first contributions, especially to get through the myriad of bots requesting you to sign/review stuff

    At the same time as they

    > can often end up taking more time away from contributing engineers doing reviews and testing than they are worth