← Back to context

Comment by M95D

2 days ago

> You could put it on your blog, in an email list, or keep it in a fork.

Get serious. Nobody's going to look into forks of a project to see what other people improved. Not even github has a search that good that would show bug fixes and improvements from forks that someone is searching for. How would you even search? (Well, to be honest, maybe Github has, or maybe Copilot can do that kind of search based on a half a page text description of what I'm looking for, but I'm really not aware that it exists.)

> By opening a PR, you make it visible to other people who also benefit from the project and who may be interested in using it.

Yeah, but if I have moral standards and care about not wasting those interested people's time, then I have to keep the PR forever maintained and rebased on current HEAD, even if I don't need to update my fork that often, or I stopped using that project altogether. If I didn't do that, then I would be a hypocrite.

> Get serious. Nobody's going to look into forks

At this point you just sound like you want to complain. I was saying that opening a PR is a nice way to share a patch, and all you get from it is an opportunity to complain about how difficult it may be to find a patch in a fork.

> Yeah, but if I have moral standards and care about not wasting those interested people's time

This has nothing to do with moral standards. I have benefitted multiple times from old, unmerged, outdated PRs. Because if someone fixes a bug, the valuable part is understanding what is going wrong and how to fix it. An outdated PR saves me that time.

> If I didn't do that, then I would be a hypocrite.

Not at all. You just have a very weird way to look at it.