← Back to context

Comment by tcoff91

16 hours ago

Most editors have some kind of way to review github PRs in your editor. VSCode has a great one. I use octo.nvim since I use neovim.

6 comments

tcoff91

Reply
nine_k  16 hours ago

Can these tools e.g. do per-commit review? I mean, it's not the UI what's the problem (though it's not ideal), it's the whole idea of commenting the entire PR at once, partly ignoring the fact that the code in it changes with more commits pushed.

Phabricator and even Gerrit are significantly nicer.

  • dathanb82  13 hours ago

    Unless you have a “every commit must build” rule, why would you review commits independently? The entire PR is the change set - what’s problematic about reviewing it as such?

    • riffraff  8 hours ago

      There's a certain set of changes which are just easier to review as stacked independent commits.

      Like, you can do a change that introduced a new API and one that updates all usages.

      It's just easier to review those independently.

      Or, you may have workflows where you have different versions of schemas and you always keep the old ones. Then you can do two commits (copy X to X+1; update X+1) where the change is obvious, rather than seeing a single diff which is just a huge new file.

      I'm sure there's more cases. It's not super common but it is convenient.