Comment by kccqzy
1 month ago
I have never worked at Facebook but I have always thought of Critique as the best code review tool I’ve used. It’s way better than GitHub. A few things I miss: (1) it has convenient and intuitive pure-keyboard navigation; (2) you can reply to code review comments in a pending form and then publish them after you update your code, because in the common case you address code review comments by updating the code; (3) until recently GitHub wouldn’t allow you to comment on lines far away from the changed lines but Critique has always allowed it, because obviously this is an important use case when the reviewer needs to point out the changed code affects some other regions; (4) it had support for diffbase so it displayed stacked CLs fine.
Critique had had a redesign between end of 2019 / start of 2020. I didn’t recall adding any significant features but it merely modernized the UI. So did Buganizer and Code Search. So if you thought the UI was clunky well it had been addressed.
Buganizer UI: https://issuetracker.google.com/issues?q=Android%2F
Code Search UI: https://source.chromium.org/chromium/chromium/src
Unfortunately I wasn’t able to find a public instance of Critique.
No comments yet
Contribute on Hacker News ↗