← Back to context

Comment by haggy

2 hours ago

First, congrats on getting healthy!

Secondly, since you're presenting this as a portfolio entry, I have some open, honest feedback. I quickly reviewed the repository and there are some pretty major orange-red flags that would dissuade employers from reaching out. Some of them include:

- Lack of coherent repository structure. All files under src/ with no sense of modularity

- The commit messages are very poor. Messages like "cool" and "jump jump" and "perf" do not provide any context to anyone outside of yourself (and probably not even you will remember what those changes were days/weeks from now)

- There are magic numbers everywhere. The biggest offender I found was in shaders.ts

There are more but those are the top ones I saw from my quick review. Again this isn't meant to discourage you. I wanted to provide the feedback to help you be more successful with potential employers. Cheers!