← Back to context

Comment by progbits

1 day ago

https://github.com/WordPress/WordPress/commit/3a640e1c5e39aa...

String concatenation SQL injection in the year 2026.

Oh it's even worse: https://developer.wordpress.org/plugins/creating-tables-with...

>Rather than executing an SQL query directly, we’ll use the dbDelta function

>Note that the dbDelta function is rather picky, however. For instance:

>You must put each field on its own line in your SQL statement.

>You must have two spaces between the words PRIMARY KEY and the definition of your primary key.

>You must use the key word KEY rather than its synonym INDEX and you must include at least one KEY.

>KEY must be followed by a SINGLE SPACE then the key name then a space then open parenthesis with the field name then a closed parenthesis.

>You must not use any apostrophes or backticks around field names.

>Field types must be all lowercase.

>SQL keywords, like CREATE TABLE and UPDATE, must be uppercase.

>You must specify the length of all fields that accept a length parameter. int(11), for example.

  • Sometimes when you write documentation for APIs you realize something is terribly designed. That should have happened here.

The WordPress codebase is a disgrace. PHP is a beautiful language by now, but they absolutely butcher it and refuse to do anything about that.

  • It's just because they don't want to break anything in existing sites, sorta like how Microsoft doesn't generally want to break programs on Windows. So, changes are fairly incremental, and the quality is about what you'd expect from a piece of software that's decades old with no plan for what happens if it got this far.

    But what do you do in that situation? If they change the structure too much, then either they make it impossible to upgrade an existing site, or potentially break a whole bunch of things said sites depend on (mostly themes and plugins). And that ease of upgrading is likely what stops a lot of people just migrating away to other solutions.

    • Even just introducing emulation layers for the old parts and making the new parts opt-in would be better than just giving up and keep on going. Plugin authors can choose the new subsystem as they publish updates or new plugins and themes, and in return they get speed and security guarantees.

      And since the WordPress foundation controls the extension marketplace, they can reliably determine which parts of the API surface are in use, or even invest a chunk of money every month to send AI-written patches to plugin maintainers to ease the transition.

      There would be so many ways to improve the situation (to the benefit of WordPress maintainers, customers, and ecosystem vendors alike, mind you!), but alas, they are stuck to their ways and will not.

      2 replies →

    • If the existing at-risk functionality is a security issue I feel like that’s a good time to throw the proverbial flag on the play and make it an issue. Letting consumers play host to malware and phishing portals is the worse move.

  • I'm convinced it's by design so that the community that build little businesses around wordpress still stay in the eco system. A client needs new functionality? That's be a week of work because god help anyone who wants to look into themselves.

    WordPress is actively degrading the security and quality of the web I general. Has been for many many years.

  • The great irony is they still sport their "Code is Poetry" mantra on their website [0].

    If code is poetry, Wordpress is a new genre of it, probably?

    [0]: https://codex.wordpress.org/WordPress_Philosophy

  • Everything I've used from Automattic has felt that way. If you ever want to torture an engineer, just make them change the layout of WooCommerce checkout.

  • As a junior I am glad I happened to start working with PHP on version 7. I had some peeks at our legacy PHP5 stuff (all killed now thankfully) and it looked very different. I am sure it would suck to work with.

    • php7 was such a great time period for PHP, honestly lots of great experimental projects around that time too (HHVM before that, etc).

      1 reply →

  • it would help if they used strict types and modern standards but as you say the wordpress codebase is beyond dated and held together with duckt tape

  • I remember multiple projects giving up on rewriting it. Maybe a machine with endless patience could do it?

    • I've done it multiple times but no one's gonna use my off the shelf blog when there's a bagilian WordPress plugins they wanna use. But with AI you kinda sorta should just build your own blog. Doctrine with slime framework. You can even throw a WordPress plugin at the LLM and ask it to implement the same thing.

      5 replies →

  • PHP is a proof that you don't need elegant or good technical solutions to be successful. You can literally pile up slop together and still be successful.

    • Yeah; the common idea of dignity and self-respect is to replace the duct tape with proper engineering once you're successful though, instead of just taping ever more of it on top and pretending SQL injections aren't really a problem.

      3 replies →

    • I think PHP came right at the time that every man and his dog was a "web developer" and writing absolute unknowledgable stuff. And PHP allowed for it.

      ASP had a bit of a barrier to entry because it required all the MS. Whereas PHP was everywhere.

  • It was like that in the old days too. Seriously who makes a postmeta table and goes "yea let's just throw everything in here. Indexes? Meh."

    I cringe everytime.

  • I don't think PHP is a beautiful language. If it was Laravel wouldn't need to rewrite every function from standard library. And, I see no reason to use it compared to Typescript.

    • I never really understood these complaints about the standard library, that's not what makes a language really. Yes, it's ugly, yes, it carries 30 years of baggage, but it's PHP the language that allows you to interact with a much more convenient abstraction layer provided by Laravel.

      PHP can run the same code fully dynamically typed or with very strict type annotations, depending on your requirements. It has runtime reflection APIs that are so cheap that you don't really have to think about using them. You can do OOP or FP with PHP, or even procedural HTML-interleaved-with-PHP if that's your thing. It has late static binding, so you can defer to child classes from their parent class. There are generators and fibres as first-class language constructs now. Property hooks are an extremely clear pattern, way better than in many other languages.

      Generally, there have been tons of new syntax extensions over the years, and they all slot in gracefully. With PHP 8.6, we're going to get partial application for functions, which will make PHP 8.5's match expressions one of the most ergonomic implementations I have seen yet!

    • Ecosystem? The JS/TS ecosystem approach is to use as many libraries as possible for the sake of it, exposing you to a massive supply chain risk. PHP doesn't suffer from that because there are barely any libraries for it.

      1 reply →

  • [flagged]

    • Let me convince you! :-)

      There are match expressions and arrow functions:

        $slug = $title
            |> trim(...)
            |> (fn($str) => str_replace(' ', '-', $str))
            |> (fn($str) => str_replace('.', '', $str))
            |> strtolower(...);
      

      There is meta-programming with annotations:

        final class PostsController
        {
            #[AccessControl(fn(Request $request, Post $post)
                => $request->user === $post->getAuthor()
            )]
            public function update(Request $request, Post $post): Response {
                // ...
            }
        }
      

      Native (and optionally value-backed) enums:

        enum Status
        {
            case Draft;
            case Published;
            case Archived;
        }
      

      Proper class property hooks, fully replacing getters and setters:

        class Data
        {
            public string $fullName {
                get => "{$this->firstName} {$this->lastName}";
                set(string $value) {
                    [$first, $last] = explode(' ', $value);
                    $this->firstName = $first;
                    $this->lastName = $last;
                }
            }
        }
      

      And tons of other features—among them asymmetric property visibility, fibres/green threads, DNF types, lazy object instantiation, an ever-improving yet fully opt-in static type system with runtime validation, a JIT compiler, an amazing package ecosystem and -manager, annotation-backed deprecation, and more.

      7 replies →

    • > Nope.

      Beauty is in the eye of the beholder, and I'll disagree kindly with you on that "Nope".

What an awful fix. Does WordPress seriously still use basic string concatenation (edit: and sprintf) to build SQL queries?

  • To construct dynamic sql queries to have to string concatenate at least some parts, .

    User data should of course be passed via prepared statements.

    • One usually uses "query builder" pattern for that.

      Also, regarding placeholders, historically many DB and frameworks do not support passing lists for a value in a placeholder (like "WHERE id IN(?)") so users of such software fall back to string concatenation.

      1 reply →

    • Not user code, no. Someone eventually has to, but virtually every ORM under the sun allows you to construct dynamic queries without having to concatenate strings yourself or resort to string interpolation.

      2 replies →

  • WordPress source code is a mess. They should re-write it from scratch using modern technologies, or even a framework like Laravel.

Ahhh very interesting! Thanks for pointing this out, I saw an attack against one of our sites this weekend using this exploit.

> data: {'requests': [{'method': 'POST', 'path': 'http://:'}, {'body': {'requests': [{'method': 'GET', 'path': 'http://:'}, {'method': 'GET', 'path': '/wp/v2/widgets?author_exclude=1%29+AND+1%3D0+UNION+ALL+SELECT+0%2C1%2C0x323...

>>Principal Software Engineer @ Bluehost. WordPress Core Committer. Baseball fan.

hmm yes, definitely. You are the principal.