← Back to context

Comment by win311fwg

18 hours ago

What is misleading about the title? A custom encoding scheme is exactly what it suggests. Maybe it has been edited since your comment was posted?

It wasn’t replacing one rust enum, it was replacing what are effectively multiple enums

  • How so? It's replacing multiple enum variants, but just one enum, "enum Value".

    (also; if anything, the title is implying the exact opposite of "Rust compiler was able to optimize ...", "Replacing a Rust [...] with [...]" is clearly moving away from Rust-magic to something else)

I'd actually point at the other half of the title than the existing comment when being pedantic "Replacing [...] with a 64-Bit Word" isn't quite right, it was replaced with a manually packed 64-Bit Word and the occasional heap allocation.

I'm not sure being this pedantic is particularly useful in titles though...

  • It's worth calling out either way. It's not just an encoding scheme, it's a reasonably significant change in architecture.