Comment by lscharen

1 day ago

Maybe something (contrived) like this providing no-op defaults?

  total = calculateOrderTotal(user.order);
  if (user.isPremiumMember) {
    total = total * 0.9;        // 10% discount

versus

  total = calculateOrderTotal(user.order);
  discount = calculateDiscount(user);  // Returns 0.9 or 1.0
  total = total * discount;

4 comments

lscharen

Didn't you just shift the branch to the calculateDiscount() function?

1718627440 18 hours ago
Not necessarily.
return 1 - user.isPremiumMember * 0.1;
would also cut it.

OK, or maybe...

  total = calculateOrderTotal(user.order);
  total = total * user.discount;

Or:

  total = calculateOrderTotal(user.order);
  total *= user.discount;

or:

  return 
         calculateOrderTotal(user.order)
       * user.discount;