← Back to context

Comment by RHSeeger

12 hours ago

> That's a strong signal that your team isn't doing well. Significant problems should have been spotted at a software design stage, or raised in standups, or identified in a pairing session.

This is a strong signal that you're looking at different things than a lot of people doing code reviews are.

- Why are you using this api for this instead of this other one? We use the other one because it avoids a specific issue.

- Your code isn't following the same patterns that we use in these places. It should be using the same patterns so that it's more obvious to anyone else that works on it

- The name you gave this function/class/whatever doesn't accurately represent what it is for

These are the kinds of things that are generally noticeable during a code review, and can make a big difference later on. And they're generally not going to be identified during standups and/or design.

Pairing is an option, since it is (effectively) code review _while_ writing the code (with a certain amount of blinders on, so not quite as effective). That being said, I hate pairing, so it's certainly not on my recommendation list.