Comment by eddythompson80
3 hours ago
I don't really know what to say tbh. I feel insane at times too but I'm being a realist and a pragmatist. I think I'm in the "changed their mind" camp because I got tired of fighting and can't deny reality. It is a losing battle. All approaches to manage changes in a traditional way also don't work. I have seen people who left because they can and I might follow suit too.
Like I think (or know) code reviews are also over. Someone asks me for a 10-11am brainstorming meeting regarding a concept they are working on, at 11:15 they have a "design doc" ready, at 1pm they ping me if I had a chance to review it yet, at 3pm I approve it, at 3:30pm they send a 7k line PR... "dude, that's not ok. I'm not reviewing 7k line change" so they say "oh yes absolutely sorry about that. that makes a lot of sense. Do you want 7 1k-line PRs? or 14 500-line PRs?" "hey Claude, split this into 10 commits and open 10 stacked PRs" :|
> Like I think (or know) code reviews are also over.
Whatever the size of code review chosen, merging totally unreviewed code to prod is still totally insane. There are a few AI code review products out there. The one I've used is fairly decent at picking out issues, though there's definitely some shortcomings vs a human reviewer with additional context (especially since not everything is written down for the bot to access). So I wouldn't say they are over. Even though the AI review isn't perfect, we all know human reviews aren't either.
As AI improves it'll be able to hold more of the codebase as context, enabling better, quicker reviews.
Yeah but who writes totally unreviewed code nowadays? Everyone I know doesn't commit until a model has reviewed the code that another model wrote.