Comment by Gigachad
8 hours ago
This is the fix commit https://github.com/google/brotli/commit/b418fa81c48262a86a95...
Another day another out of bounds access in C code.
8 hours ago
This is the fix commit https://github.com/google/brotli/commit/b418fa81c48262a86a95...
Another day another out of bounds access in C code.
Can someone point the heart of this fix? I see a bunch of change of naming of constants, etc
As far as I understand it's line 1978: `goto saveStateAndReturn;`. Early return that prevents further processing.
Doesn't mix up error-need-more-data with error-invalid-data
Had a short moment to glance at it. My guess would be BROTLI_DCHECK(s>meta_block_remaining_len <= (int)BROTLI_BLOCK_SIZE_CAP) along with BROTLI_SAFE_WITH_STATUS having that goto saveStateAndReturn on non BROTLI_DECODER_SUCCESS.