← Back to context Comment by ks2048 9 hours ago Can someone point the heart of this fix? I see a bunch of change of naming of constants, etc 3 comments ks2048 Reply red75prime 9 hours ago As far as I understand it's line 1978: `goto saveStateAndReturn;`. Early return that prevents further processing. cowlevel 6 hours ago Doesn't mix up error-need-more-data with error-invalid-data therein 7 hours ago Had a short moment to glance at it. My guess would be BROTLI_DCHECK(s>meta_block_remaining_len <= (int)BROTLI_BLOCK_SIZE_CAP) along with BROTLI_SAFE_WITH_STATUS having that goto saveStateAndReturn on non BROTLI_DECODER_SUCCESS.
red75prime 9 hours ago As far as I understand it's line 1978: `goto saveStateAndReturn;`. Early return that prevents further processing.
therein 7 hours ago Had a short moment to glance at it. My guess would be BROTLI_DCHECK(s>meta_block_remaining_len <= (int)BROTLI_BLOCK_SIZE_CAP) along with BROTLI_SAFE_WITH_STATUS having that goto saveStateAndReturn on non BROTLI_DECODER_SUCCESS.
As far as I understand it's line 1978: `goto saveStateAndReturn;`. Early return that prevents further processing.
Doesn't mix up error-need-more-data with error-invalid-data
Had a short moment to glance at it. My guess would be BROTLI_DCHECK(s>meta_block_remaining_len <= (int)BROTLI_BLOCK_SIZE_CAP) along with BROTLI_SAFE_WITH_STATUS having that goto saveStateAndReturn on non BROTLI_DECODER_SUCCESS.