Comment by whateveracct
5 years ago
Nothing wrong with patching
Part of the beauty of Nix is it's easy to maintain patches - this can be nice cost-wise compared to upstreaming in many cases.
Not saying upstreaming isn't a generally good thing, but it's nice to have this other option.
Generally if the patch is not-specific to nixpkgs, we ask the contributor to upstream the patch, and then we have a `fetchpatch` utility which makes it easy to pull from an upstream source.