Comment by ComputerGuru

2 years ago

Shameless plug: another option to format sizes in a human readable format quickly and correctly (other than copying from S/O), you can use one of our open source PrettySize libraries, available for rust [0] and .NET [1]. They also make performing type-safe logical operations on file sizes safe and easy!

The snippet from S/O may be four lines but these are much more extensive, come with tests, output formatting options, conversion between sizes, and more.

[0]: https://github.com/neosmart/prettysize-rs

[1]: https://github.com/neosmart/PrettySize.net

9 comments

ComputerGuru

Reply
drunkendog  2 years ago

Replacing 4 line solutions with extensive libraries is what caused left-pad.

  • Analemma_  2 years ago

    I understand where you're coming from here, but the whole point of this article is at the 4-line solution is wrong (and the author specifically mentioned that every other answer on the stack overflow post was wrong in the same way as well). "Seemingly-simple problem where every naïve solution contains a subtle bug" is exactly the right use case for a well-designed library method.

    • riversflow  2 years ago

      > “It’s wrong”

      But in a completely benign way. I question why a few edge cases of writing 1000kb instead of 1Mb—so not even a misrepresentation—would ever be worth the code bloat. This is about making stuff slightly more convenient to read.

      2 replies →

  • Cthulhu_  2 years ago

    Yeah, copying an incorrect answer from SO thousands of times is much better!

    (The subject at hand isn't whether libraries are good or not, it's whether copying something off the internet is. In the post, it turns out it isn't. If it was a library, the author could have fixed and updated the library, and the issue would be fixed for everyone that uses it. left-pad isn't an issue with libraries per se, it's an issue with library management)

  • LoganDark  2 years ago

    No. left-pad was placing a 4-line solution in a library. prettysize is well deserving of library status.