Comment by matijsvzuijlen
2 years ago
The idea is that --amend would be used before pushing the commit that it amends, and so before a reviewer ever sees the original commit.
2 years ago
The idea is that --amend would be used before pushing the commit that it amends, and so before a reviewer ever sees the original commit.
The idea of PR review is that the submission is imperfect and that there will be fixes. Like, "typo fix" fixes.
Yes, but the history presented upthread looks much more like someone working before submitting a PR for review, rather than changes made in response to review. How much to amend the history at each step is several separate questions.