Comment by abetusk
1 year ago
This looks great.
Some feedback:
* reposition markers to make item it's referencing clear. In particular, the marker 6 (C) completely obscures the text on the jar
* allow a toggle for markers to be unhighlighted or partially transparent so what's underneath them can be seen or the image can be appreciated without annotations
* I'm not sure how to do this with the current layout or if a different layout would work but having 'hover highlighting' for the annotations/markers so you could look at a marker and see where they are in the picture would be nice.
* provide licensing information
- It looks like the image itself is copyright Gary Overacre under a CC-BY-NC-ND (I'm not even sure if the annotations overlaid are considered derivatives) [0]
- Provide licensing information for your code and annotations. Normally this is just copyright yourself but considering the context it would be good to clarify what license you want things under, especially if you're taking contributions
[0] https://archive.org/details/unix-magic-poster-gary-overcare-...
Thank you for the feedback.
> Reposition markers to make the item they're referencing clear. In particular, marker 6 (C) completely obscures the text on the jar.
I agree, and I'll take care of that. It’s a bit tricky because the marker’s exact position can shift slightly depending on the display being used, but I’ll adjust it for better clarity.
> Allow a toggle for markers to be unhighlighted.
Yes, this will be especially useful as we add more markers. I already have at least 50 more in mind that I plan to include.
> Having 'hover highlighting' for the annotations/markers.
I intentionally designed the layout this way to ensure the image and annotations remain functional across different screen types without introducing overly complex logic. That said, I’m sure someone with more expertise in web development could refine this further.
> Licensing information.
100%. I’ll add that shortly.