Comment by karel-3d

2 months ago

I have only experience with Chrome codebase and while it's C++ (which I don't personally like) it's pretty solid and most of the weird hairy stuff were the external linked libraries. But I didn't poke around THAT much.

Remember "25000 string allocations per each key stroke"? https://groups.google.com/a/chromium.org/g/chromium-dev/c/EU...

  • That's certainly interesting but to give context for those not following the link: This is for entering into the address/search bar, so it covers all the work of searching history, performing network requests to autocomplete search terms, and displaying those results. It's not like entering a character into a regular text box on a page.

    • IMO no amount of context can justify 25000 string allocations per key stroke :)

      Also, if you read the issues in the first post, it has nothing to do with "covering all the work". It's just really bad programming

Using badly written external linked library is bad software engineering / quality too as the responsibility lies into who are linking it.