Comment by parpfish

2 days ago

Don’t forget the in place variant!

  the_dict |= update_keys_and_values_dict

No no, do forget about it: like += for lists, |= mutates “the dict”, which often makes for awkward bugs.

And like += over list.extend, |= over dict.update is very little gain, and restricts legal locations (augmented assignments are statements, method calls are expressions even if they return "nothing")

  • The |= does exactly what it says on the tin. How could it not mutate the left side of the assignment?

    • > The |= does exactly what it says on the tin. How could it not mutate the left side of the assignment?

      The normal way? If the LHS is an integer. |= updates the binding but does not mutate the object.

      Nothing requires that |= mutate the LHS let alone do so unconditionally (e.g. it could update the LHS in place as an optimisation iff the refcount indicated that was the only reference, which would optimise the case where you create a local then update it in multiple steps, but would avoid unwittingly updating a parameter in-place).

      edit: you might not be understanding what dict.__ior__ is doing:

        >>> a = b = {}
        >>> c = {1: 2}
        >>> b |= c
        >>> a
        {1: 2}
      

      That is, `a |= b` does not merely desugar to `a = a | b`, dict.__ior__ does a `self.update(other)` internally before updating the binding to its existing value. Which also leads to this fun bit of trivial (most known from list.__iadd__ but "working" just as well here):

        >>> t = ({},)
        >>> t[0] |= {1: 2}
        Traceback (most recent call last):
          File "<stdin>", line 1, in <module>
        TypeError: 'tuple' object does not support item assignment
        >>> t
        ({1: 2},)

      2 replies →

    • In typed languages, I’m all about using nice safe immutable variables/values.

      But in python, everything is mutable so there’s only so much safety you can wring out of adhering the an immutable style. Any other function can hop in and start mutating things (even your “private” attributes). Plan for mutations occurring everywhere.

      1 reply →