Comment by luke-stanley
3 months ago
I am very picky, hard to place, but from a quick look at the README, I'd say the API interface on display seemed like the right level of abstraction for having to deal with the messy reality.
Since you're asking for feedback:
- perhaps some of the document type specific dependencies by optional?
- could there be LESS config surface?
- I noticed GitHub CI action has a cross.
It's good to add how to use with Astral "uv" these days, especially anything that might pull in PyTorch dependency hell, which they have mostly solved if used correctly!
Nice work!
Love this kind of feedback, thank you. You nailed it on optional deps and config sprawl; I’m trimming both. CI cross is just coverage noise, and I’ll add uv setup notes it really cleans up the PyTorch mess. Glad the API felt right — that was the hardest part to get “just enough abstraction” right.