Comment by dpkirchner
2 days ago
I must be missing something huge here, or maybe it's the wine -- how is the code in PR 3157 (referenced in a later comment) a proper fix?
https://github.com/actions/runner/pull/3157/files
Is : doing something unusual in GH actions?
The original loop is:
while (time() != timeout) {;}
The fixed loop is:
while (time() < timeout) {;}
I see. I did not realize SECONDS was a built in bash variable.
It is still not a proper fix. It is still busy-looping 100% CPU.
Given that Github Actions is quite popular, probably wasting large amount of energy.
But probably good at generating billable Actions minutes.
One can only hope that not many people use sleeps to handle their CI race conditions, as that itself is also not a proper fix.
9 replies →
Me neither. I am over 40 and did not know this. Feels good to learn something today, in an unexpected place!