Comment by biorach

2 days ago

The point is that it ended up in the PR in the first place. The submitted seemed unaware of its presence and only looked into it after it was pointed out. This is sloppy and is a major red flag.

So there's no point? Sloppy maybe yes but technically incorrect or legally questionable no. Struggle is real

  • If the submitter is sloppy with things that are not complicated, how can one be sure of things that ARE complicated?

    • The funny thing is that it works, have a look at the MR. It says:

        All existing tests pass. Additional DWARF tests verify:
      
        DWARF structure (DW_TAG_compile_unit, DW_TAG_subprogram).
        Breakpoints by function and line in both GDB and LLDB.
        Type information and variable visibility.
        Correct multi-object linking.
        Platform-specific relocation handling.
      

      So the burden of proof is obviously not anymore on the MR submitter side but the other.