Comment by djoldman

10 hours ago

> _canonicalize_table = str.maketrans( "ABCDEFGHIJKLMNOPQRSTUVWXYZ_.", "abcdefghijklmnopqrstuvwxyz--", )

> ...

> value = name.translate(_canonicalize_table)

> while "--" in value:

> value = value.replace("--", "-")

translate can be wildly fast compared to some commonly used regexes or replacements.

4 comments

djoldman

Reply
est  9 hours ago

I am curious, why not .lower().translate('_.', '--')

  • fwip  8 hours ago

    .lower() has to handle Unicode, right? I imagine the giant tables slow it down a bit.

teaearlgraycold  9 hours ago

I would expect however that a regex replacement would be much faster than your N^2 while loop.

  • notpushkin  8 hours ago

    It would be, if it was a common situation.

    This loop handles cases like `eggtools._spam` → `eggtools-spam`, which is probably rare (I guess it’s for packages that export namespaced modules, and you probably don’t want to export _private modules; sorry in advance for non-pythonic terminology). Having more than two separator characters in a row is even more unusual.