Comment by tayo42

20 days ago

Did you try it? If it doesn't work there's also called once if you scroll up on the doc

And as far as whether it's a good idea or not, I generally wouldn't, but was saying when it is important then you do have these tools available,llms aren't the first thing to check for these mistakes. It's up to the engineer to choose between trade offs for your scenario.

3 comments

tayo42

Reply
shagie  20 days ago

Yes. The test passes. https://imgur.com/a/4qlTKlc

To try to monkey patch this in, you would need to also assert that it wasn't called with [2, 4, 6, 8, 10].

At which point, I would again ask "why are you testing that it _wasn't_ called with a given set of values?"

The comment at the root of this is "Unit tests catch that kind of stuff".

... But unit tests aren't for testing internals of implementation but rather observable aspects of a function.

Consider if the code was written so that it was

    def print_evens(nums):
        for n in nums:
            if n % 2 == 0:
                print(n)

instead (with the filter being used in func())

This isn't something that unit tests can (or should) identify. It would come out in a code review that there is redundant functionality in func and print_evens.

Using ChatGPT or another tool to assist in doing code reviews can be helpful (my original premise).

https://chatgpt.com/share/697a64a6-33c0-8011-a0f8-ca4fec74ab...

ChatGPT properly identifies the duplicated functionality (even though the code is using different idioms for doing the filtering for even numbers).

  • tayo42  20 days ago

    The test pass because your patching print_even so the 2nd filter is never called.

    Which I guess, idk maybe think through the testing more and your code more before jumping to conclusions about how things are?

    Testing is one tool you have, and it can test the internal like this. Obviously there's a use for it if its in the Python stdlib

    This is in mockito

    https://stackoverflow.com/questions/39452438/mockito-how-to-...

    this is in google testing library for cpp

    https://google.github.io/googletest/gmock_for_dummies.html

    > Specify your expectations on them (How many times will a method be called? With what arguments? What should it do? etc.).

    If you never heard of this, I guess you learned something new? Im not a tutor though. I would read the docs more and experiment. Maybe chatgpt can help you with how tests can be written.

    • shagie  20 days ago

      With Mockito, I can mock the returned result of someCall().

      However, it also means mocking list.stream() and mocking the Stream for stream.filter() and mock the call stream.toList() to return a new mocked object that has those mocks on it again.

      I could catch the object passed in to printEven(...) but that has no history on it to see if filter was called on it before.

      Trying to do the filter(...) call would be especially hard since you'd be parameterize it with a code block.

      And all this returns to "is this a useful test?"

      Testing should only be done on the observable parts of the function. Does printEven only print even numbers?

      The tests that you are proposing are testing the implementation of those calls to work in a specific way. "It must call filter" - but if it's changed to a different filter or if it's changed to not use a filter but has the same functionality the code breaks.

      Inefficient? Yes. Bad? Yes. Wrong - no. And not being wrong it isn't something that a unit test could validate without going unnecessarily into the implementation of the internals for the method. Internals changing while the contract remains the same is perfectly acceptable and shouldn't be breaking a unit test.