Comment by arcfour

4 months ago

Closing the PR without providing feedback beyond "needs further discussion" does not engender said further discussion.

3 comments

arcfour

Reply
PunchyHamster  4 months ago

PR isn't a place for discussion about what or how to implement change in the first place, that should be forum/mailing list/issues

and there is open issue for that discussion https://codeberg.org/forgejo/forgejo/issues/8634

  • radlad  4 months ago

    #8634 is specifically about a breaking change that occurred in v12. It's literally the first line of what you linked:

    > In the v12 release of Forgejo (fixed in v12.0.1) there have been breaking changes that impact third-party authentication sources that use Forgejo as a provider. If you have been affected, please help us assessing the impact ...

henryteeare  4 months ago

The response was, "needs a discussion," as in a post on `https://codeberg.org/forgejo/discussions`, rather than directly creating a PR.

There also was feedback saying approximately that they've been burned by security changes in the recent past and don't want to run into similar issues without due consideration.