Comment by ddkto
19 hours ago
The best part is that copilot commented on the PR saying that this doesn’t actually change the behaviour, creates inconsistency in the codebase and suggested reverting the change! (This comment seems to have been ignored…)
> The configuration schema default was changed to "all", but the runtime fallback in extensions/git/src/repository.ts still calls config.get('addAICoAuthor', 'off'). This is now out of sync and can lead to unexpected behavior in contexts where the contributed configuration defaults aren't loaded (e.g., some tests/hosts), and it makes the intended default unclear. Update the runtime fallback to match the schema default (or omit the fallback so the contributed default is used).
Constructive feedback: revert it and then apologise instead of just doing half of it.
That's pretty standard review practice in there by now.
But it was apparently ignored.
It wasn’t ignored, the second commit fixes what the bot suggested
I also liked the bot posting screenshot diffs that are all false positives, while apparently not capturing the default change (is it not in some menu somewhere?)
There are two commits in the PR, the second of the two seems to update the fallback config to avoid the inconsistency that Copilot was complaining about.